Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install bindgen in the build environment #1435

Closed
wants to merge 1 commit into from

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jun 24, 2021

I tested locally that this only installs bindgen when new versions are
published, not on every build.

Fixes #444.

r? @Nemo157

I tested locally that this only installs bindgen when new versions are
published, not on every build.
@jyn514 jyn514 added S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed A-builds Area: Building the documentation for a crate labels Jun 24, 2021
@Nemo157
Copy link
Member

Nemo157 commented Jun 24, 2021

rust-lang/cargo#5730 is fixed with the new resolver, and nrfxlib-sys has updated to rely on that, are there any other crates still relying on this? (Eventually rust-lang/rfcs#3028 would allow having a build-dependency on the bindgen binary if for some reason crates want to call it as a CLI instead of a library).

@jyn514
Copy link
Member Author

jyn514 commented Jun 24, 2021

Hmm, that's a good point - I'd forgotten the original reason they used the binary.

I don't know any way we could check this. I guess we can close the issue and see if anyone complains?

@Nemo157
Copy link
Member

Nemo157 commented Jun 24, 2021

Yeah, the lack of "me too" comments on the issue makes me think it's a pretty rare problem, and now that it's fixed upstream everyone should hopefully migrate to resolver = "2".

@jyn514 jyn514 closed this Jun 24, 2021
@jyn514 jyn514 deleted the bindgen branch June 24, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-builds Area: Building the documentation for a crate S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nrfxlib needs bindgen binary to build
2 participants