Set explicit font size for topbar #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syphar
approved these changes
Jan 22, 2022
There was a problem hiding this comment.
manual test is fine,
@GuillaumeGomez could you review the impl?
syphar
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Jan 22, 2022
|
Looks good to me, just one question: did this issue appear after a specific rustdoc version? If so, please do like #1579. |
syphar
added
S-waiting-on-author
|
My understanding is that before the new CSS version, rustdoc specified 16px itself. So docs.rs specifying it again won't change anything, and adding a new copy of the docs.rs CSS just for this seems like overkill. |
|
Yes, @jyn514 has it exactly right. The problem appeared after a specfic rustdoc version, but it's safe and correct to apply this style with all rustdoc versions, so we shouldn't split off a new copy of the CSS for it. |
syphar
removed
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/rust#93171.
Explanation: Since rust-lang/rust#92448, the docs.rs topbar will misbehave when the user's font size is >16px. Some items in the navbar will overflow their allotted height of 33px. This wasn't happening before because the navbar was inheriting rustdoc's styles on the
<body>element, which includedfont-size: 16px. It turns out docs.rs was implicitly relying on thatfont-size: 16px, so add it here explicitly.To test: Set your browser font-size to anything >16px. Visit a documentation page. It should have the normal width.
/cc @cynecx @GuillaumeGomez @syphar