Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable outline on focused rustdoc element to workaround safari performance issue #750

Merged
merged 1 commit into from
May 6, 2020

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented May 6, 2020

Tested on Safari 13.1 and Safari Tech Preview 13.2, fixes scrolling issues on the rustdoc portion of the page when it's focused (as happens automatically whenever the page is navigated to) and stops the page from jumping around when switched to.

Tested on some pages in production via userstyle injection as well, to see that it works with pages built with older rustdoc.

fixes #725

@jyn514
Copy link
Member

jyn514 commented May 6, 2020

r? @GuillaumeGomez

cc #595 which may be related.

@GuillaumeGomez
Copy link
Member

I don't have any apple device so I can only trust you on this one. Let's merge then...

@GuillaumeGomez GuillaumeGomez merged commit 103cacc into rust-lang:master May 6, 2020
@Nemo157 Nemo157 deleted the safari-why branch May 31, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Low FPS on Safari 13.1
3 participants