pin-utils crate & remove glob imports #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MajorBreakfast
commented
Aug 7, 2018
| //! assert_eq!(6, *block_on(shared1)); | ||
| //! assert_eq!(6, *block_on(shared2)); | ||
| //! # } | ||
| //! ``` |
There was a problem hiding this comment.
I removed this module description because module is private and we don't have descriptions in the other modules.
cramertj
reviewed
Aug 7, 2018
| @@ -12,11 +12,6 @@ | |||
|
|
|||
| #![doc(html_root_url = "https://rust-lang-nursery.github.io/futures-doc/0.3.0-alpha.2/futures_channel")] | |||
|
|
|||
| #[cfg(feature = "std")] | |||
There was a problem hiding this comment.
Oh, I didn't think about that. We'll have to take care not to accidentally use std symbols in our no_std build, because there won't be anything preventing them in CI (since std is still reachable via a path).
There was a problem hiding this comment.
I'm pretty sure that this will catch them:
There was a problem hiding this comment.
Yeah, that'd get it. I opened rust-lang/rust#53166 to discuss this.
|
Thanks, this looks great! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pin-utilscrateextern cratestatementsusestatements to import macrosuse futures::prelude::*statements from code examples