Add StreamExt::buffer_unordered_adaptable #1956
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llebout
force-pushed
the
buffer-unordered-adaptable
branch
5 times, most recently
from
a94e5eb
to
16a0866
Compare
It might be desirable to have adaptative parallelism for the processing of buffered futures. An example use case would be to cope with the ever changing network conditions when sending requests to a remote host. One might collect metrics about the performance of the data transfer and adapt the parallelism parameters as necessary to maximize throughput.
llebout
force-pushed
the
buffer-unordered-adaptable
branch
from
16a0866
to
2134e4d
Compare
|
Finally, CI is successful. thumbv6m-none-eabi does not have atomic instructions? how does it even multi core? |
|
Nice work on this pull request! Exactly what I was looking for in a personal project. In regards to your question, according to rust-lang/rust#54250, it seems that the platform simply does not support certain atomic operations in hardware. |
… buffer-unordered-adaptable
…s-rs into buffer-unordered-adaptable
taiki-e
requested changes
Jun 16, 2021
There was a problem hiding this comment.
Thanks for the PR and sorry for the late review!
I'm okay with adding such a feature, but I would like to have tests and docs for the following cases:
maxis0whenbuffer_unordered_adaptableis called.maxwas not0whenbuffer_unordered_adaptableis called, but changed to0.
taiki-e
added
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be desirable to have adaptative parallelism for the
processing of buffered futures.
An example use case would be to cope with the ever changing
network conditions when sending requests to a remote host.
One might collect metrics about the performance of the
data transfer and adapt the parallelism parameters as
necessary to maximize throughput.