Add select benchmark
#2582
Merged
Add select benchmark
#2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
pushed a commit
that referenced
this pull request
Aug 14, 2022
Merged
taiki-e
pushed a commit
that referenced
this pull request
Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to optimize
select, by making it take data that implements aStrategytrait, instead of a closure. Didn't seem to work, but it seems like a good function to benchmark.Next try will be to make it stop calling
.poll_next()on a stream when it terminates, and removing theFuselayer. Might just be that these details are getting lost in the noise though.