Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FillBuf: Do not call poll_fill_buf twice #2812

Merged
merged 1 commit into from
Dec 8, 2023
Merged

FillBuf: Do not call poll_fill_buf twice #2812

merged 1 commit into from
Dec 8, 2023

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Dec 7, 2023

@taiki-e taiki-e added A-io Area: futures::io 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Dec 7, 2023
@taiki-e taiki-e merged commit 5e35c12 into master Dec 8, 2023
24 checks passed
@taiki-e taiki-e deleted the io-fill-buf branch December 8, 2023 13:36
@flokli
Copy link

flokli commented Dec 16, 2023

poke :-) Can this be backported to 0.3 and a release tagged? 🙏

@taiki-e taiki-e mentioned this pull request Dec 24, 2023
@taiki-e taiki-e added 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Dec 24, 2023
@taiki-e
Copy link
Member Author

taiki-e commented Dec 24, 2023

Published in 0.3.30.

tvlbot pushed a commit to tvlfyi/tvix that referenced this pull request Dec 24, 2023
The bugs have been fixed,
rust-lang/futures-rs#2801 and
rust-lang/futures-rs#2812 were merged and ended
up in that release.

Change-Id: Iefd990d2d1719b884504093343e54e9c5258e2e2
Reviewed-on: https://cl.tvl.fyi/c/depot/+/10414
Reviewed-by: raitobezarius <[email protected]>
Autosubmit: flokli <[email protected]>
Tested-by: BuildkiteCI
tvlbot pushed a commit to tvlfyi/tvix that referenced this pull request Dec 24, 2023
The bugs have been fixed,
rust-lang/futures-rs#2801 and
rust-lang/futures-rs#2812 were merged and ended
up in that release.

Change-Id: I301c0ffc951f04a5b3b7267e922771c837a3f5a9
Reviewed-on: https://cl.tvl.fyi/c/depot/+/10415
Autosubmit: flokli <[email protected]>
Tested-by: BuildkiteCI
Reviewed-by: raitobezarius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants