Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Mention for library/portable-simd #393

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Mention for library/portable-simd #393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions highfive/configs/rust-lang/rust.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,10 @@
"src/tools/tidy": ["@Mark-Simulacrum"]
},
"mentions": {
"library/portable-simd": {
"message": "library/portable-simd is a subtree of https://github.com/rust-lang/portable-simd and changes here will have to be cherry-picked upstream.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message reads a little to me like it's suggesting that either (a) the change should not be made in rust-lang/rust or (b) that the author is responsible for cherry-picking upstream. I think neither of those are generally true, so I wonder if we can try to figure out a slightly clearer message, maybe just by tagging on a "This is something the project group will take care of, so you don't need to worry about it." or similar.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, from this perspective, many of our messages here are not great, it's just that this is being added and so is coming under slightly more scrutiny by me :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh, it is somewhat preferred if it can be avoided! But I agree that it is Not Necessarily True, just a weak preference in the case where there's no other reason not to, so I am fine with changing the message. The real thing that would be consistently desired, I think, would be that the commits should be structured so that cherry-picking the diff out is easy (it is much more annoying if the same commit diffs both library/portable-simd and the rest of the tree, and structuring a PR in certain ways, like preferring rebasing, is already imposed on contributors) and yes, that it needs to alert someone to do that.

I would rather Insinuate Something, even if that could be misinterpreted, than the more... nondescript quality of most of these messages. Presenting a total void of context is more alarming, in my experience as a contributor, than implying something about preferred processes. A suggestive direction points towards what might be more ideal, and even if misinterpretable, increases confidence about directions. The more ambiguous messages accept any interpretation, decreasing confidence about any direction, almost to the point of inducing anxiety.

"reviewers": ["@rust-lang/project-portable-simd"]
},
"src/rustdoc-json-types": {
"message": "rustdoc-json-types is a **public** (although nightly-only) API. If possible, consider changing `src/librustdoc/json/conversions.rs`; otherwise, make sure you bump the `FORMAT_VERSION` constant.",
"reviewers": ["@CraftSpider", "@aDotInTheVoid"]
Expand Down