Add CI build jobs for all supported targets even if libc-test is not set up for them #1229
Comments
gnzlbg
added a commit
to gnzlbg/libc
that referenced
this issue
Jan 29, 2019
gnzlbg
added a commit
to gnzlbg/libc
that referenced
this issue
Feb 5, 2019
gnzlbg
added a commit
to gnzlbg/libc
that referenced
this issue
Feb 6, 2019
gnzlbg
added a commit
to gnzlbg/libc
that referenced
this issue
Feb 7, 2019
This commit adds a `ci/build.sh` script that checks that libc builds correctly for some common configurations (`--no-default-features`, `default`, `extra_traits`) on most targets supported by Rust since Rust 1.13.0 (the oldest Rust version that libc supports). The build matrix is refactored into two stages. The first stage is called `tools-and-build-and-tier1` and it aims to discover issues quickly by running the documentation and linter builds, as well as checking that the library builds correctly on all targets in all supported channels and "problematic" Rust versions; Rust versions adding major new features like `repr(align)`, `union`, etc. This first stage also runs libc-test for the tier-1 targets on linux and osx. These builds finish quickly because no emulation is necessary. The second stage is called `tier2` and it runs libc-test for all other targets for which we are currently able to do so. Closes rust-lang#1229 .
gnzlbg
added a commit
to gnzlbg/libc
that referenced
this issue
Feb 7, 2019
This commit adds a `ci/build.sh` script that checks that libc builds correctly for some common configurations (`--no-default-features`, `default`, `extra_traits`) on most targets supported by Rust since Rust 1.13.0 (the oldest Rust version that libc supports). The build matrix is refactored into two stages. The first stage is called `tools-and-build-and-tier1` and it aims to discover issues quickly by running the documentation and linter builds, as well as checking that the library builds correctly on all targets in all supported channels and "problematic" Rust versions; Rust versions adding major new features like `repr(align)`, `union`, etc. This first stage also runs libc-test for the tier-1 targets on linux and osx. These builds finish quickly because no emulation is necessary. The second stage is called `tier2` and it runs libc-test for all other targets for which we are currently able to do so. Closes rust-lang#1229 .
gnzlbg
added a commit
to gnzlbg/libc
that referenced
this issue
Feb 7, 2019
This commit adds a `ci/build.sh` script that checks that libc builds correctly for some common configurations (`--no-default-features`, `default`, `extra_traits`) on most targets supported by Rust since Rust 1.13.0 (the oldest Rust version that libc supports). The build matrix is refactored into two stages. The first stage is called `tools-and-build-and-tier1` and it aims to discover issues quickly by running the documentation and linter builds, as well as checking that the library builds correctly on all targets in all supported channels and "problematic" Rust versions; Rust versions adding major new features like `repr(align)`, `union`, etc. This first stage also runs libc-test for the tier-1 targets on linux and osx. These builds finish quickly because no emulation is necessary. The second stage is called `tier2` and it runs libc-test for all other targets for which we are currently able to do so. Closes rust-lang#1229 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are some targets that we "support" (e.g. most *BSDs except FreeBSD), but for which we don't have any build jobs. We should add build jobs for these that check that libc cross-compiles correctly for these targets, even if we don't run
libc-testto check libc's ABI.This should at least make sure that these targets have no trivial compilation errors, and would also allow us to run the normal lints for these (clippy, make sure that all traits are implemented for the types available in these targets, etc.).
The text was updated successfully, but these errors were encountered: