-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add powerpc64 and powerpc64le support #133
Conversation
@@ -83,9 +83,11 @@ s! { | |||
} | |||
|
|||
pub struct pthread_mutexattr_t { | |||
#[cfg(target_arch = "x86_64")] | |||
#[cfg(any(target_arch = "x86_64", target_arch = "powerpc64", | |||
target_arch = "powerpc64le"))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change this to target_pointer_width
? Looks like that may be what's in play here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hit an aarch64 fail, looks like it requires 8 byte alignment: https://travis-ci.org/rust-lang-nursery/libc/jobs/101784088
I'll back that change out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol of course, oh well
b046185
to
cc698a5
Compare
@@ -416,7 +405,10 @@ cfg_if! { | |||
if #[cfg(any(target_arch = "x86", target_arch = "arm"))] { | |||
mod b32; | |||
pub use self::b32::*; | |||
} else if #[cfg(any(target_arch = "x86_64", target_arch = "aarch64"))] { | |||
} else if #[cfg(any(target_arch = "x86_64", | |||
target_arch = "aarch64", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you align these target_arch
directives?
r+ from me, if you rebase it should retrigger travis and I'll merge |
When rebasing, do you want me to squash the commits? |
Either way's fine by me, feel free to do whatever's easiest On Tuesday, January 12, 2016, Anton Blanchard [email protected]
|
cc698a5
to
6dfc29e
Compare
Ah looks like this needs another rebase :( (I kinda wish github had a way for me to automatically do that...) |
A number of libc constants are different on PowerPC64 Linux, so push them down into arch specific files.
6dfc29e
to
c4f676b
Compare
Sorry that was my fault. This should be now rebased to latest. |
Add powerpc64 and powerpc64le support
* Add _mm256_shuffle_epi8 * Add _mm256_permutevar8x32_epi32
PowerPC64 Linux does not implement fstat64, stat64 and lstat64, so
disable them. A number of constants for system calls are different
to x86, so fix that too.