Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add powerpc64 and powerpc64le support #133

Merged
merged 1 commit into from
Jan 13, 2016

Conversation

antonblanchard
Copy link
Contributor

PowerPC64 Linux does not implement fstat64, stat64 and lstat64, so
disable them. A number of constants for system calls are different
to x86, so fix that too.

@@ -83,9 +83,11 @@ s! {
}

pub struct pthread_mutexattr_t {
#[cfg(target_arch = "x86_64")]
#[cfg(any(target_arch = "x86_64", target_arch = "powerpc64",
target_arch = "powerpc64le"))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change this to target_pointer_width? Looks like that may be what's in play here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, will do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hit an aarch64 fail, looks like it requires 8 byte alignment: https://travis-ci.org/rust-lang-nursery/libc/jobs/101784088

I'll back that change out

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol of course, oh well

@antonblanchard antonblanchard force-pushed the powerpc64_merge branch 2 times, most recently from b046185 to cc698a5 Compare January 12, 2016 12:15
@@ -416,7 +405,10 @@ cfg_if! {
if #[cfg(any(target_arch = "x86", target_arch = "arm"))] {
mod b32;
pub use self::b32::*;
} else if #[cfg(any(target_arch = "x86_64", target_arch = "aarch64"))] {
} else if #[cfg(any(target_arch = "x86_64",
target_arch = "aarch64",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you align these target_arch directives?

@alexcrichton
Copy link
Member

r+ from me, if you rebase it should retrigger travis and I'll merge

@antonblanchard
Copy link
Contributor Author

When rebasing, do you want me to squash the commits?

@alexcrichton
Copy link
Member

Either way's fine by me, feel free to do whatever's easiest

On Tuesday, January 12, 2016, Anton Blanchard [email protected]
wrote:

When rebasing, do you want me to squash the commits?


Reply to this email directly or view it on GitHub
#133 (comment)
.

@alexcrichton
Copy link
Member

Ah looks like this needs another rebase :(

(I kinda wish github had a way for me to automatically do that...)

A number of libc constants are different on PowerPC64 Linux, so push
them down into arch specific files.
@antonblanchard
Copy link
Contributor Author

Sorry that was my fault. This should be now rebased to latest.

alexcrichton added a commit that referenced this pull request Jan 13, 2016
Add powerpc64 and powerpc64le support
@alexcrichton alexcrichton merged commit 9aa6600 into rust-lang:master Jan 13, 2016
@antonblanchard antonblanchard deleted the powerpc64_merge branch August 30, 2016 22:44
danielverkamp pushed a commit to danielverkamp/libc that referenced this pull request Apr 28, 2020
* Add _mm256_shuffle_epi8

* Add _mm256_permutevar8x32_epi32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants