Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct MIPS types of SA_* flags #135

Merged
merged 1 commit into from
Jan 12, 2016

Conversation

alexcrichton
Copy link
Member

Missed out correction from 6ac75c1

@tamird
Copy link
Contributor

tamird commented Jan 12, 2016

@alexcrichton it seems that sigaction.sa_flags and all the SA_* flags are signed here, but the linux headers disagree: https://github.com/torvalds/linux/blob/master/arch/mips/include/uapi/asm/signal.h#L105

Is this deviation intentional?

Missed out correction from 6ac75c1
@alexcrichton
Copy link
Member Author

@tamird it is indeed, we updated to a newer toolchain of MIPS which has change the type to int. As to why the kernel and libc disagree, I'm not sure.

@tamird
Copy link
Contributor

tamird commented Jan 12, 2016

Hm, seems odd. Another point of disagreement https://android.googlesource.com/platform/bionic/+/master/libc/kernel/uapi/asm-mips/asm/signal.h#96 nevermind, the android version is unsigned here.

alexcrichton added a commit that referenced this pull request Jan 12, 2016
@alexcrichton alexcrichton merged commit 95d6a00 into rust-lang:master Jan 12, 2016
@alexcrichton alexcrichton deleted the fix-mips-flags branch January 12, 2016 20:01
danielverkamp pushed a commit to danielverkamp/libc that referenced this pull request Apr 28, 2020
* [travis-ci] deny warnings

* fix all warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants