Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeBSD's Capsicum constants #3628

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Mar 22, 2024

Thanks for considering submitting a PR!

We have the contribution guide. Please read it if you're new here!

Here's a checklist for things that will be checked during review or continuous integration.

  • Edit corresponding file(s) under libc-test/semver when you add/remove item(s), e.g. edit linux.txt if you add an item to src/unix/linux_like/linux/mod.rs
  • Your PR doesn't contain any private or unstable values like *LAST or *MAX (see #3131)
  • If your PR has a breaking change, please clarify it
  • If your PR increments version number, it must NOT contain any other changes (otherwise a release could be delayed)
  • Make sure ci/style.sh passes
  • cd libc-test && cargo test
    • (this might fail on your env due to environment difference between your env and CI. Ignore failures if you are not sure)

Delete this line and everything above before opening your PR.

@rustbot
Copy link
Collaborator

rustbot commented Mar 22, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@asomers
Copy link
Contributor Author

asomers commented Mar 22, 2024

The CI failures are unrelated.

asomers added a commit to asomers/capsicum-rs that referenced this pull request Mar 22, 2024
@asomers
Copy link
Contributor Author

asomers commented Mar 22, 2024

Note that the CAP_RIGHTS_VERSION constant violates the rule against unstable constants. It's a version number used to tell the kernel which version of the other CAP_* rights the program is using. So I think it's appropriate to include it here. We must increment it in the future if there's a ever a new version of the rights.

@JohnTitor JohnTitor added this pull request to the merge queue Apr 20, 2024
Merged via the queue into rust-lang:main with commit d106c9f Apr 20, 2024
41 checks passed
@asomers asomers deleted the capsicum branch May 13, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants