Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getpid in wasi #3670

Merged
merged 1 commit into from
May 3, 2024
Merged

Add getpid in wasi #3670

merged 1 commit into from
May 3, 2024

Conversation

youknowone
Copy link
Contributor

@youknowone youknowone commented Apr 30, 2024

Add getpid from wasi-libc. getpid in wasi itself doesn't make sense, but wasi-libc defines an emulated function which returns a constant value.

I found semver/wasi.txt doesn't exist. Do I need to create it?

@rustbot
Copy link
Collaborator

rustbot commented Apr 30, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@youknowone youknowone marked this pull request as draft April 30, 2024 10:12
@youknowone youknowone marked this pull request as ready for review April 30, 2024 10:19
@JohnTitor JohnTitor added this pull request to the merge queue May 3, 2024
Merged via the queue into rust-lang:main with commit 89241f0 May 3, 2024
41 checks passed
@youknowone youknowone deleted the wasi-getpid branch May 3, 2024 02:06
@youknowone
Copy link
Contributor Author

@JohnTitor I am really sorry. This one need to be reverted.

rust-lang/rust#124554 (comment)

The function is not placed in libc.a

@JohnTitor
Copy link
Member

Alright 👍, created a revert PR: #3679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants