Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MODULE_INIT_COMPRESSED_FILE definition #3783

Conversation

sinkingpoint
Copy link

Opening this alongside #3782 to backport the const into libc-0.2 so that we can use it in nix

@rustbot
Copy link
Collaborator

rustbot commented Jul 22, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@sinkingpoint sinkingpoint force-pushed the sinkingpoint/sinkingpoint/MODULE_INIT_COMPRESSED_FILE-libc-0.2 branch from becb9e3 to 7f0b238 Compare July 25, 2024 07:15
@tgross35
Copy link
Contributor

We are slightly changing the workflow here - PRs should target main, then they will get cherry-picked to stable if applicable. So I am going to close this and stable-nominate #3782 (which I will review once I get the chance).

@tgross35 tgross35 closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants