Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define SO_BINDTOIFINDEX on Fuchsia #3784

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Define SO_BINDTOIFINDEX on Fuchsia #3784

merged 1 commit into from
Aug 12, 2024

Conversation

ewilden
Copy link
Contributor

@ewilden ewilden commented Jul 22, 2024

@rustbot
Copy link
Collaborator

rustbot commented Jul 22, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@ewilden ewilden marked this pull request as ready for review July 22, 2024 15:22
@ewilden
Copy link
Contributor Author

ewilden commented Jul 22, 2024

I assume the failed CI check for macOS is a flake? I don't think this change would have impacted macOS 🤷

@devnexen
Copy link
Contributor

I assume the failed CI check for macOS is a flake? I don't think this change would have impacted macOS 🤷

not at all :)

@ewilden
Copy link
Contributor Author

ewilden commented Jul 29, 2024

I assume the failed CI check for macOS is a flake? I don't think this change would have impacted macOS 🤷

not at all :)

Please elaborate - does "not at all" refer to the failure being a flake, or are you saying I'm incorrect and that this does indicate my change impacts macOS?

@devnexen
Copy link
Contributor

no I meant your change has nothing to do with the macos failure

@ewilden
Copy link
Contributor Author

ewilden commented Jul 30, 2024

Forgive me if I'm wrong, but from browsing the other PR discussions it looks like I don't have a way to get the mac CI to rerun other than asking @JohnTitor to kick it off.

@tgross35 tgross35 disabled auto-merge August 12, 2024 18:53
@tgross35 tgross35 added this pull request to the merge queue Aug 12, 2024
Merged via the queue into rust-lang:main with commit 687fd6f Aug 12, 2024
39 checks passed
@ewilden
Copy link
Contributor Author

ewilden commented Aug 16, 2024

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 16, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 17, 2024
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants