Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freebsd moving the kinfo_file type to general use. #3801

Merged
merged 1 commit into from
Aug 13, 2024
Merged

freebsd moving the kinfo_file type to general use. #3801

merged 1 commit into from
Aug 13, 2024

Conversation

devnexen
Copy link
Contributor

but keeping the constant KINFO_FILE_SIZE for intel archs only.

@rustbot
Copy link
Collaborator

rustbot commented Aug 12, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35
Copy link
Contributor

New workflow, we will merge #3800 first then cherry pick it. Nominated #3800 for stable.

@tgross35 tgross35 closed this Aug 12, 2024
@tgross35 tgross35 reopened this Aug 12, 2024
@tgross35 tgross35 mentioned this pull request Aug 12, 2024
Closed
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 12, 2024
@tgross35
Copy link
Contributor

Reposting from #3800 (comment), I closed the wrong PR:

Thanks, do you have a link to docs/headers for KINFO_FILE_SIZE to confirm?

This should have an update in libc-test/semver.

@rustbot label +stable-nominated

@devnexen
Copy link
Contributor Author

sure here the header.

@tgross35
Copy link
Contributor

Great, thanks for the reference. Could you add kinfo_file to libc-test/semver/freebsd.txt?

tgross35
tgross35 approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgross35 tgross35 added this pull request to the merge queue Aug 12, 2024
@devnexen
freebsd moving the kinfo_file type to general use.
34942a5 
but keeping the constant KINFO_FILE_SIZE for intel archs only.
@tgross35 tgross35 mentioned this pull request Aug 12, 2024
Open
Merged via the queue into rust-lang:main with commit 5020c76 Aug 13, 2024
39 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 13, 2024
@devnexen @tgross35
freebsd moving the kinfo_file type to general use.
c224f48 
but keeping the constant KINFO_FILE_SIZE for intel archs only.

[Resolved conflicts - Trevor]
(backport <rust-lang#3801>)
(cherry picked from commit 34942a5)
Signed-off-by: Trevor Gross <[email protected]>
@tgross35 tgross35 mentioned this pull request Aug 13, 2024
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devnexen @rustbot @tgross35 @JohnTitor