Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal-versions CI #207

Merged
merged 3 commits into from
Aug 24, 2024
Merged

Add minimal-versions CI #207

merged 3 commits into from
Aug 24, 2024

Conversation

NobodyXu
Copy link
Contributor

Help discover bugs in version requ
irements

@NobodyXu
Copy link
Contributor Author

cc @Byron seems like libz-sys is ok?

I'm not sure if I'm running with the right feature set

@Byron
Copy link
Member

Byron commented Aug 24, 2024

Even though it says it uses minimal versions, I am missing cargo update with minimal versions set. Right now it would use Cargo.lock or the latest available, I think.

@NobodyXu
Copy link
Contributor Author

Thanks, I was braindead when writing this 😂

@Byron Byron force-pushed the patch-1 branch 7 times, most recently from 60242ed to 1c8b254 Compare August 24, 2024 07:10
@Byron
Copy link
Member

Byron commented Aug 24, 2024

I tried to get the actual Cargo-zng.toml file tested as well, but on Windows it's failing as it appears to be unable to find visual studio related environment variables, and I couldn't figure out why.
So I just left it untested, but applied the expected fix anyway.

Once CI is green I can create a new release and then fix flate2, which ultimately fixes gitoxide.

@Byron Byron merged commit 38087fc into rust-lang:main Aug 24, 2024
48 checks passed
@NobodyXu NobodyXu deleted the patch-1 branch August 24, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants