Add support for abort panics #1058
Labels
A-meta
Not about any part of Miri per se, but about shaping the environment to make something in/with Miri
A-panics
Area: affects panics and unwinding
C-enhancement
Category: a PR with an enhancement or an issue tracking an accepted enhancement
Comments
RalfJung
added
A-meta
This was referenced Sep 18, 2020
Merged
bors
added a commit
that referenced
this issue
Sep 18, 2020
support panic=abort This adds support for abort-on-panic (#1058). To achieve this, we insert `cargo-miri` as `RUSTC` when building the standard library, and patch the rustc flags in a way similar to what bootstrap does. However, this is currently not supported on Windows as the Windows code uses inline assembly to cause an abort (?!?). I'll submit a rustc PR with some `cffg(miri)` to make that work. (EDIT: that would be rust-lang/rust#76871) Cc `@Aaron1011` r? `@oli-obk`
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
Sep 19, 2020
support panic=abort in Miri This is needed for rust-lang/miri#1058 on Windows: we cannot run the inline-assembly versions of `abort`, so fall back to the intrinsic (which Miri supports).
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
Sep 19, 2020
support panic=abort in Miri This is needed for rust-lang/miri#1058 on Windows: we cannot run the inline-assembly versions of `abort`, so fall back to the intrinsic (which Miri supports).
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
Sep 19, 2020
support panic=abort in Miri This is needed for rust-lang/miri#1058 on Windows: we cannot run the inline-assembly versions of `abort`, so fall back to the intrinsic (which Miri supports).
RalfJung
added a commit
to RalfJung/rust
that referenced
this issue
Sep 20, 2020
support panic=abort in Miri This is needed for rust-lang/miri#1058 on Windows: we cannot run the inline-assembly versions of `abort`, so fall back to the intrinsic (which Miri supports).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Once #693 is merged, we will have support for unwind panics. However, we will not support abort panics, due to a quirk in how
libpanic_abortis compiled.I've opend a rust PR to fix the underlying issue: rust-lang/rust#66489. Once it's merged (or another solution is found), we can re-enable these tests
The text was updated successfully, but these errors were encountered: