Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test ensuring that drop terminator of no-drop type is a NOP #2737

Closed
RalfJung opened this issue Dec 22, 2022 · 1 comment · Fixed by #3483
Closed

Add test ensuring that drop terminator of no-drop type is a NOP #2737

RalfJung opened this issue Dec 22, 2022 · 1 comment · Fixed by #3483

Comments

@RalfJung
Copy link
Member

In rust-lang/rust#103957 we realized that Miri's treatment of Drop terminators subtly differed from that of the codegen backends. That got fixed, but we don't have a test for that. Not sure if a test is even possible, but we custom_mir it might be?

Cc @JakobDegen
@JakobDegen
Copy link
Contributor

It will be once I add storage statements at least. Will do so then

@RalfJung RalfJung mentioned this issue Apr 18, 2024
Merged
@bors bors closed this as completed in c305e20 Apr 18, 2024
RalfJung pushed a commit to RalfJung/rust that referenced this issue Apr 20, 2024
@bors
Auto merge of rust-lang#3483 - RalfJung:drop, r=RalfJung
0f44382 
add test for Drop terminator on non-drop type

Fixes rust-lang/miri#2737
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add test for Drop terminator on non-drop type RalfJung/miri
2 participants
@RalfJung @JakobDegen