Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using old-style simd_shuffle #350

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jul 10, 2023

Found while fixing rust-lang/rust#113500 (this PR is not necessary, but will allow us to make the compiler simpler)

@workingjubilee
Copy link
Member

Will be landing #352 first.

@workingjubilee
Copy link
Member

@oli-obk In the newly-introduced CI, the toolchain is pinned to a specific nightly. This PR should probably unpin it, unless there's some other inscrutable compiler error barring that. Note that I am happy to call this "passing" CI if we still have 26 successes and 7 failures on CI.

@workingjubilee
Copy link
Member

how the fuck was that legal

@workingjubilee
Copy link
Member

...hmm.

@workingjubilee
Copy link
Member

I swear I am going to set this repo on fire.

@workingjubilee
Copy link
Member

CI why are you like this.

@workingjubilee
Copy link
Member

Ah there we go.

It is currently tracked separately from rust-toolchain.toml
@workingjubilee workingjubilee merged commit 8b5a04f into rust-lang:master Jul 28, 2023
26 of 33 checks passed
@workingjubilee
Copy link
Member

Thank you! I will try to land some more CI fixes/PRs and then cut 3.9 soon!

@oli-obk oli-obk deleted the old_style_simd branch July 28, 2023 06:49
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 4, 2023
…workingjubilee

Forbid old-style `simd_shuffleN` intrinsics

Don't merge before rust-lang/packed_simd#350 has made its way to crates.io

We used to support specifying the lane length of simd_shuffle ops by attaching the lane length to the name of the intrinsic (like `simd_shuffle16`). After this PR, you cannot do that anymore, and need to instead either rely on inference of the `idx` argument type or specify it as `simd_shuffle::<_, [u32; 16], _>`.

r? `@workingjubilee`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants