Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message when a library is not found #158

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Improve error message when a library is not found #158

merged 4 commits into from
Dec 20, 2023

Commits on Jul 24, 2023

  1. Improve error message when library not found 

    Mostly just small tweaks to existing output, including the following new output:
- Potential packages to install
- Items in PKG_CONFIG_PATH
- Command invocation
    @Finchiedev
    Finchiedev committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    d5be171 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Wrap std::process::Command to track arguments and environment varia… 

    …bles

Before, this was accomplished by using `get_env` and `get_args` manually, but these features are unavailable in 1.30 (current MSRV). To get around this, `Command` is wrapped as `WrappedCommand` and tracks any environment variables or arguments that are set by the caller. Then, the `Display` implementation actually handles pretty-printing the invocation, with the added benefit that other errors can take advantage of this nicer output!
    @Finchiedev
    Finchiedev committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    a0640aa View commit details
    Browse the repository at this point in the history

  2. Print correct variable name for search path 

    As pointed out by @sdroege in rust-lang#158, Nix users would be misled when
`PKG_CONFIG_PATH_FOR_TARGET` is listed in error output but mistakenly
named `PKG_CONFIG_PATH`.
    @Finchiedev
    Finchiedev committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    1ac32cd View commit details
    Browse the repository at this point in the history

  3. Fix compilation for 1ac32cd on Rust 1.30

    @Finchiedev
    Finchiedev committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    08a1c5f View commit details
    Browse the repository at this point in the history