Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming of use_std feature #474

Closed
dtolnay opened this issue May 2, 2018 · 2 comments
Closed

Naming of use_std feature #474

dtolnay opened this issue May 2, 2018 · 2 comments

Comments

@dtolnay
Copy link
Member

dtolnay commented May 2, 2018

The C-FEATURE guideline discourages calling a Cargo feature "use_std". I would recommend "std" instead.
@BurntSushi
Copy link
Member

Funnily enough, I was using std, but switched to use_std just before the release because it's what libc uses.

I think this can be done in a backwards compatible way, but we'd need to keep use_std around. Not sure whether I prefer just use_std or having both...

@ethanpailes
Copy link
Contributor

Personally I would rather have just one way to do it. Small api surface and all that.

@BurntSushi BurntSushi mentioned this issue May 2, 2018
Closed
BurntSushi added a commit that referenced this issue Sep 2, 2019
@BurntSushi
feature: add 'std' feature, deprecated 'use_std'
697db58 
We'll remove 'use_std' in regex 2, but keep it around for backward
compatibility.

Fixes #474
BurntSushi added a commit that referenced this issue Sep 2, 2019
@BurntSushi
feature: add 'std' feature, deprecate 'use_std'
afc1b76 
We'll remove 'use_std' in regex 2, but keep it around for backward
compatibility.

Fixes #474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BurntSushi @dtolnay @ethanpailes