Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump thread_local version and test on Rust 1.3. #209

Merged
merged 1 commit into from
Apr 22, 2016

Conversation

BurntSushi
Copy link
Member

Fixes #206.

@Amanieu
Copy link
Member

Amanieu commented Apr 22, 2016

I don't think bumping the version number is necessary since Cargo will automatically pick up the new version.

@BurntSushi
Copy link
Member Author

I think it's necessary to specify a minimum bound, otherwise it's not guaranteed that Cargo will pick up the new version? (e.g., If there's some other constraint on the version of thread_local in a build.) I might be misunderstanding though.

@alexcrichton
Copy link
Member

Yeah this way regex say it's only compatible with 0.2.4 and above (which I believe is the correct case)

@alexcrichton alexcrichton merged commit 0626026 into master Apr 22, 2016
@alexcrichton alexcrichton deleted the update-thread-local branch April 22, 2016 16:20
@BurntSushi
Copy link
Member Author

@alexcrichton So, I hadn't merged this yet because I don't think it will build on Rust 1.3 on Windows. :P So I guess we technically support Rust 1.3+ on Linux and Rust 1.4+ on Windows.

@alexcrichton
Copy link
Member

Gah oops! Sorry about that :(

Out of curiosity, is there one place these version dependencies are coming from? Or are they just for convenience?

@BurntSushi
Copy link
Member Author

@alexcrichton I think I'm just sympathetic to the "your build just broke because a semver bump required a newer Rust." I don't think we have any policy on it yet, but maybe it's time to talk about it? :-)

@BurntSushi BurntSushi mentioned this pull request Apr 22, 2016
@alexcrichton
Copy link
Member

Yeah seems fine to me, I'll add an item to our agenda.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants