-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix example in documentation #361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I actually prefer the &caps["year"]
approach better, since it's more likely to match up with what you'll need in actual code. That is, caps["year"]
has type str
, which usually doesn't work.
Also, could you include the string Fixes #359
in the commit message and make sure the PR is squashed to one commit?
Thanks for doing this!
Thanks!! I changed the approach and added |
@rap2hpoutre We unfortunately don't use the Github UI to merge PRs. Instead, we have a bot do it (which checks that the merge passes CI before pushing to master, which Github doesn't do). To squash, just do |
Done! Thanks again! |
Poifect! Thanks! @bors r+ |
📌 Commit b9ac569 has been approved by |
Fix example in documentation see #359 I choose to write: ```rust assert_eq!("2010".to_string(), caps["year"]); ``` But I could have choose: ```rust assert_eq!("2010", &caps["year"]); ``` Not sure which one is the best (maybe none of them)
☀️ Test successful - status-appveyor, status-travis |
see #359
I choose to write:
But I could have choose:
Not sure which one is the best (maybe none of them)