Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(lib): improve section for empty matches #897

Merged
merged 1 commit into from
Jul 26, 2022
Merged

docs(lib): improve section for empty matches #897

merged 1 commit into from
Jul 26, 2022

Conversation

mrl5
Copy link
Contributor

@mrl5 mrl5 commented Jul 24, 2022

this improvement is a consequence of the Q&A discussion from
#896

BurntSushi
BurntSushi requested changes Jul 25, 2022
View reviewed changes
Copy link
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you make sure lines are wrapped in a style consistent with the surrounding code? In this case, that's 79 columns inclusive.

@mrl5
docs(lib): improve section for empty matches
00cdcee 
this improvement is a consequence of the Q&A discussion from
rust-lang#896
@mrl5 mrl5 requested a review from BurntSushi July 26, 2022 04:15
BurntSushi
BurntSushi approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BurntSushi BurntSushi merged commit 159a63c into rust-lang:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurntSushi BurntSushi BurntSushi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrl5 @BurntSushi