Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unapprove placement RFCs #2387

Merged
merged 1 commit into from
Apr 12, 2018

Conversation

aidanhs
Copy link
Member

@aidanhs aidanhs commented Apr 3, 2018

@Centril Centril added the T-lang Relevant to the language team, which will review and decide on the RFC. label Apr 3, 2018
@JustAPerson
Copy link

At first I was confused to see this, but after reading the linked threads I'm glad that you and others remain motivated in seeking perfection in this area! Thank you! We must be competitive with C++ :)

@kennytm
Copy link
Member

kennytm commented Apr 4, 2018

Nitpick: "Retract" would be a more common term?

@aidanhs
Copy link
Member Author

aidanhs commented Apr 4, 2018

Is that common language for taking something accepted out of circulation? I tend to associate it with abandoning a proposal that hasn't been approved yet. I'd be happy using the language that another community/body/organisation users, but I couldn't think of any examples to draw from.

@clarfonthey
Copy link
Contributor

Could go with "retroactively closed/postponed." I'd say that these have been retroactively postponed to indicate that while the RFCs were originally accepted, in hindsight it makes more sense to act as if they were postponed, because they need better design to satisfy the guarantees.

@mark-i-m
Copy link
Member

mark-i-m commented Apr 4, 2018

Repealed?

@clarfonthey
Copy link
Contributor

Question: do we need an FCP to revert an FCP?

@Ixrec
Copy link
Contributor

Ixrec commented Apr 5, 2018

Personally I think "retract" is the best term, though it's by a very small margin. Nitpicky arguments:

"Repeal" sounds too legalistic to me. It makes me imagine RFCs as proposals to modify the standardese text of the ISO Rust specification, such that repealing one in the future would imply making the opposite modification to the specification text. I think "Retract" manages to strike the ideal balance of sounding professionally formal without quite crossing into legalistically, only-comprehensible-for-wizards formal.

"Retroactively closed/postponed" sounds like the RFC should have been closed/postponed a long time ago, but for whatever reason it fell through the cracks and we simply forgot to do so. Since we accepted and implemented this RFC, then removed the implementation, that doesn't quite sound right to me.

"Unaccepted" would be my #2 choice. I like it slightly less than "retract" only because it sounds similar to "unacceptable", which is a somewhat judgmental word. But that's the only tiebreaker nitpick I can come up with.

(no objections to the actual PR, I'm just bikeshedding)

@aidanhs
Copy link
Member Author

aidanhs commented Apr 5, 2018

All: I love bikeshedding but if anyone has any examples of other communities etc doing something similar with some wording that we could steal I'd love it even more :)

Question: do we need an FCP to revert an FCP?

@clarcharr that happened in rust-lang/rust#48333 (comment)

@nikomatsakis
Copy link
Contributor

We discussed in the @rust-lang/lang meeting and decided to resist the alluring bikeshed and just merge as is. (Note that FCP on this decision has already occurred.)

@nikomatsakis nikomatsakis merged commit 1c353bc into rust-lang:master Apr 12, 2018
@aidanhs aidanhs deleted the aphs-no-place-for-placement branch April 23, 2018 15:47
@Centril Centril added A-expressions Term language related proposals & ideas A-placement-new Proposals relating to placement new / box expressions. A-syntax Syntax related proposals & ideas labels Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-expressions Term language related proposals & ideas A-placement-new Proposals relating to placement new / box expressions. A-syntax Syntax related proposals & ideas T-lang Relevant to the language team, which will review and decide on the RFC.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants