Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline assembly #2873

Merged
merged 68 commits into from
Jul 20, 2020
Merged

Inline assembly #2873

merged 68 commits into from
Jul 20, 2020

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Mar 3, 2020

A redesigned asm! macro, with a path to stabilization.

Rendered

Implementation PR

This thread is a continuation of #2850, which has grown rather large. All of the feedback from the previous thread has been incorporated in the RFC.

@Amanieu Amanieu mentioned this pull request Mar 3, 2020
```

Note that the `fn` or `static` item does not need to be public or `#[no_mangle]`:
the compiler will automatically insert the appropriate mangled symbol name into the assembly code.
Copy link
Member

@anp anp Jul 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add another note here re: rust-lang/rust#73911 that #[track_caller] functions refer to an indirect shim?

@rfcbot rfcbot added the finished-final-comment-period The final comment period is finished for this RFC. label Jul 9, 2020
@rfcbot
Copy link
Collaborator

rfcbot commented Jul 9, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@rfcbot rfcbot removed the final-comment-period Will be merged/postponed/closed in ~10 calendar days unless new substational objections are raised. label Jul 9, 2020
onehr added a commit to onehr/core-os-riscv that referenced this pull request Jul 10, 2020
From [RFC 2873](rust-lang/rfcs#2873):

> The existing `asm!` macro will be renamed to `llvm_asm!` to provide an
easy way to maintain backwards-compatibility with existing code using
inline asm.
@nikomatsakis nikomatsakis merged commit 1660857 into rust-lang:master Jul 20, 2020
@nikomatsakis
Copy link
Contributor

Huzzah! The @rust-lang/lang team has decided to accept this RFC. You can follow along at the following places:

jedisct1 pushed a commit to jedisct1/rust-precision that referenced this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ASM Proposals related to embedding assemly into Rust. disposition-merge This RFC is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this RFC. T-lang Relevant to the language team, which will review and decide on the RFC.
Projects
None yet
Development

Successfully merging this pull request may close these issues.