This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Return only modified lines in formatting responses #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Xanewok I'll try to take a look in the week but unfortunately I'm quite busy at the moment. |
Xanewok
force-pushed
the
rustfmt-modified-lines
branch
2 times, most recently
from
728d16b
to
50910d7
Compare
Xanewok
commented
Mar 5, 2019
|
☔ The latest upstream changes (presumably #1402) made this pull request unmergeable. Please resolve the merge conflicts. |
Xanewok
force-pushed
the
rustfmt-modified-lines
branch
2 times, most recently
from
6b6f307
to
5d9cb76
Compare
Xanewok
force-pushed
the
rustfmt-modified-lines
branch
from
5d9cb76
to
e17a9e4
Compare
|
@bors r+ |
|
📌 Commit e17a9e4 has been approved by |
bors
added a commit
that referenced
this pull request
Apr 6, 2019
Return only modified lines in formatting responses Ticks few boxes in #3. (that's an early issue!) Closes #334. This is currently based on rust-lang/rustfmt#3424 and so currently blocked until it merges. Configures Rustfmt to use `EmitMode::ModifiedLines` and parses the response - this should work with both statically-linked and externally provided Rustfmt. @alexheretic do you think you could take a look and double-check?
|
☀️ Test successful - checks-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticks few boxes in #3. (that's an early issue!)
Closes #334.
This is currently based on rust-lang/rustfmt#3424 and so currently blocked until it merges.
Configures Rustfmt to use
EmitMode::ModifiedLinesand parses the response - this should work with both statically-linked and externally provided Rustfmt.@alexheretic do you think you could take a look and double-check?