This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Pass file directory as cwd for Run test of CodeLens #1584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous implementation:
When there is a Cargo Workspace including several member packages, clicking CodeLens Run test button in source code files of a member package triggers shell execution
cargo test -- --no-capture ...
without specifying a current working directory.It appears that the default cwd is the Workspace / top-level package root (as expected).Consequently, no targeted tests are actually perfomed as
cargo test
does not cover member packages unless--workspace
is specified.To fix the problem, there are two feasible ways:
--workspace
option tocargo test
.The first way is much slower than the second as it takes more time to filter out unnecessary tests outside current member packages.
So this commit passes the file directory as
Cmd.cwd
in CodeLensCommand
to rls-vscode so thatcargo test ...
can be executed with proper cwd.