This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Remove unused clap dependency #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're right. Now that I actually look through the code, it doesn't seem to actually reference That explains why I got no compiler errors when I bumped it... |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 10, 2022
…mulacrum Bump to clap 3 This PR, along with several others, will entirely remove the Clap 2 dependency from the rust source tree. * rust-lang/rust-installer#114 * rust-lang/rls#1779 This PR includes a submodule bump for rust-installer, which includes the following PRs: * rust-lang/rust-installer#114 * rust-lang/rust-installer#113 * rust-lang/rust-installer#115
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes several dependencies from RLS, since it already indirectly depends on Clap 3 because of Cargo.