Update to rustc_lexer version 660 #4590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `unescape_*()` to `unescape_literal()`.
* Done at line 243: "Add validation of `crate` keyword not appearing in the middle of the symbol path" * Already happened: "Remove validation of unterminated literals (it is already implemented in `tokenize()`)" * Happens in `unescape()`: "Add validation of character literal containing only a single char" * Missing: "raw string literals and raw byte string literals"
|
#4574 includes this, but I'll rebase it over your PR (for the FIXME changes). |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 24, 2020
4590: Update to rustc_lexer version 660 r=matklad a=Julian-Wollersberger Change the `unescape_*()` functions to `unescape_literal()`, to address the canges I made in rust-lang/rust#72047. I also noticed some outdated FIXMEs. Co-authored-by: Julian Wollersberger <[email protected]>
|
Not sure what's up with bors.... bors r+ |
|
Already running a review |
|
bors r- |
|
Canceled. |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
unescape_*()functions tounescape_literal(), to address the canges I made in rust-lang/rust#72047.I also noticed some outdated FIXMEs.