Fix bitfields on big-endian machines. #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upsuper
reviewed
Jun 30, 2018
| @@ -27,7 +27,12 @@ where | |||
| let byte_index = index / 8; | |||
| let byte = self.storage.as_ref()[byte_index]; | |||
|
|
|||
| let bit_index = index % 8; | |||
| let mut bit_index = index % 8; | |||
| #[cfg(target_endian = "big")] | |||
There was a problem hiding this comment.
It probably should use some runtime target information rather than build time config, because people may want to cross-compile.
There was a problem hiding this comment.
That's fine though, isn't it? This code is included in the target code.
There was a problem hiding this comment.
Oh, this is the code bindgen adds to the generated binding file. That makes sense then.
|
Sorry for the lag here, this looks fine but the tests need to be updated. I'll get to it ASAP. |
|
@bors-servo r+ |
|
📌 Commit a642894 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jul 1, 2018
Fix bitfields on big-endian machines. Fixes #1340
|
☀️ Test successful - status-travis |
Closed
emilio
added a commit
to emilio/rust-bindgen
that referenced
this pull request
Jul 1, 2018
…es, and fix formatting issues. Followup to rust-lang#1342
bors-servo
pushed a commit
that referenced
this pull request
Jul 1, 2018
codegen: Allow unused_mut to prevent warnings on little-endian machines. And fixup whitespace. This is a followup #1342.
emilio
added a commit
to emilio/rust-bindgen
that referenced
this pull request
Jul 1, 2018
bors-servo
pushed a commit
that referenced
this pull request
Jul 1, 2018
codegen: Allow unused_mut to prevent warnings on little-endian machines. And fixup whitespace. This is a followup #1342.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1340