ir: Don't assume wchar is 2 bytes. #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fitzgen |
This was referenced Jul 5, 2018
fitzgen
approved these changes
Jul 5, 2018
| @@ -2978,6 +2978,12 @@ impl TryToRustTy for Type { | |||
| IntKind::ULong => Ok(raw_type(ctx, "c_ulong")), | |||
| IntKind::LongLong => Ok(raw_type(ctx, "c_longlong")), | |||
| IntKind::ULongLong => Ok(raw_type(ctx, "c_ulonglong")), | |||
| IntKind::WChar { size } => { | |||
| let ty = Layout::known_type_for_size(size) | |||
| .expect("Non-representable wchar_t?"); | |||
There was a problem hiding this comment.
Is this really something we should expect vs return an Err?
There was a problem hiding this comment.
Yes, I think we should always be able to represent it.
If there's no sufficiently large rust type to represent multi-byte characters I want to know why :)
|
@bors-servo r=fitzgen |
|
📌 Commit b3e41a2 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jul 6, 2018
ir: Don't assume wchar is 2 bytes. Fixes #1345
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1345