Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document BINDGEN_EXTRA_CLANG_ARGS env variable #1795

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

tmfink
Copy link
Contributor

@tmfink tmfink commented Jun 5, 2020

Feature was originally introduced in pull-request #1537

Feature was originally introduced in pull-request rust-lang#1537
@tmfink
Copy link
Contributor Author

tmfink commented Jun 5, 2020

I was hunting for this feature and couldn't find it in the documentation.
I finally found the original pull request via Google, which is less than ideal.

I understand that for most users this is not required (or recommended), but when you need this it's important. I think leaving out the documentation is worse than keeping the documentation.

We should probably also add it to the README (since end consumers of bindgen will probably look there first).

Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this. Yeah, adding this to either the book or the README would be appreciated!

@emilio emilio merged commit 117e2a1 into rust-lang:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants