Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arithmetic_side_effects not triggered when add_assign used #12318

Closed
jayvdb opened this issue Feb 20, 2024 · 1 comment · Fixed by #12692
Closed

arithmetic_side_effects not triggered when add_assign used #12318

jayvdb opened this issue Feb 20, 2024 · 1 comment · Fixed by #12692
Assignees
@c410-f3r
Labels
C-bug Category: Clippy is not doing the correct thing I-false-negative Issue: The lint should have been triggered on code, but wasn't

Comments

@jayvdb
Copy link

jayvdb commented Feb 20, 2024 •
edited by rustbot
Loading

Summary

Where foo += 1 would trigger arithmetic_side_effects, the lint can be silenced by using foo.add_assign(1).

Likely this applies to all of the traits in https://doc.rust-lang.org/std/ops/index.html#traits

Lint Name

arithmetic_side_effects

Reproducer

No response

Version

rustc 1.76.0 (07dca489a 2024-02-04)
binary: rustc
commit-hash: 07dca489ac2d933c78d3c5158e3f43beefeb02ce
commit-date: 2024-02-04
host: x86_64-unknown-linux-gnu
release: 1.76.0
LLVM version: 17.0.6
@jayvdb jayvdb added C-bug Category: Clippy is not doing the correct thing I-false-negative Issue: The lint should have been triggered on code, but wasn't labels Feb 20, 2024
@c410-f3r
Copy link
Contributor

@rustbot claim

@ijackson ijackson mentioned this issue Mar 21, 2024
Open
@c410-f3r c410-f3r mentioned this issue Apr 18, 2024
Merged
bors added a commit that referenced this issue Apr 22, 2024
@bors
Auto merge of #12692 - c410-f3r:arrrr, r=Manishearth
7fcaa60 
[arithmetic_side_effects] Fix #12318

Fix #12318

changelog: [arithmetic_side_effects]: Consider method calls that correspond to arithmetic symbols
@bors bors closed this as completed in 2a4dae3 Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c410-f3r c410-f3r

Labels
C-bug Category: Clippy is not doing the correct thing I-false-negative Issue: The lint should have been triggered on code, but wasn't
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[arithmetic_side_effects] Fix #12318 c410-f3r/rust-clippy
2 participants
@jayvdb @c410-f3r