Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new lint [single_range_in_vec_init] #10934

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

Centri3
Copy link
Member

@Centri3 Centri3 commented Jun 12, 2023

Lints on vec![0..200] (or [0..200]), suggesting either (0..200).collect::<Vec<i32>>() or [0; 200].

Haven't tested it with anything that isn't primitive. Probably should!

Closes #10932

changelog: new lint [single_range_in_vec_init]

@rustbot
Copy link
Collaborator

rustbot commented Jun 12, 2023

r? @giraffate

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 12, 2023
Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, thanks! I made some comments.

clippy_lints/src/single_range_in_vec_init.rs Outdated Show resolved Hide resolved
clippy_lints/src/single_range_in_vec_init.rs Outdated Show resolved Hide resolved
@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Jun 14, 2023

📌 Commit 830d307 has been approved by giraffate

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 14, 2023

⌛ Testing commit 830d307 with merge 823d9dd...

@bors
Copy link
Collaborator

bors commented Jun 15, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing 823d9dd to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a lint for when ranges are used inside of a Vec
4 participants