Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc_tools_util: rerun when git commit changes #13329

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Sep 1, 2024

Fixes #13312

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Sep 1, 2024

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 1, 2024
@RalfJung RalfJung force-pushed the git-commit-rerun branch 3 times, most recently from 4e2c942 to 67fd516 Compare September 1, 2024 10:45
rustc_tools_util/src/lib.rs Outdated Show resolved Hide resolved
@RalfJung RalfJung force-pushed the git-commit-rerun branch 2 times, most recently from ec77894 to c96586d Compare September 9, 2024 11:15
@RalfJung
Copy link
Member Author

RalfJung commented Oct 5, 2024

@Alexendoo it's been a month -- any feedback on this PR? :)

Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait, having to rebuild on each commit/checkout is unfortunate but at least it's only the top level package and not clippy_utils/clippy_lints

rustc_tools_util/src/lib.rs Outdated Show resolved Hide resolved
rustc_tools_util/src/lib.rs Outdated Show resolved Hide resolved
rustc_tools_util/src/lib.rs Outdated Show resolved Hide resolved
@RalfJung RalfJung force-pushed the git-commit-rerun branch 8 times, most recently from 35ae117 to 6b8c6f6 Compare October 5, 2024 19:27
@Alexendoo
Copy link
Member

Thanks!

@flip1995 what's the process for getting a new release out for rustc_tools_util?

@flip1995
Copy link
Member

flip1995 commented Oct 7, 2024

I can create a release after this is merged. @RalfJung Can you bump the version of rustc_tools_util in the Cargo.toml to 0.4.0 before merging, please? (Not sure if a patch bump would also be sufficient. There were quite some changes since the last release)

@RalfJung
Copy link
Member Author

RalfJung commented Oct 7, 2024

Eh, that makes some tests fail? Is that expected? Seems quite painful if tests need to be adjusted for each version bump of this crate...

@flip1995
Copy link
Member

flip1995 commented Oct 7, 2024

Hm, it tests itself, by running the macro on itself. Bumping the 3 versions in the tests fixes the test breakage. It's unfortunate, but as we're not updating this very often, I think this is fine.

@flip1995
Copy link
Member

flip1995 commented Oct 7, 2024

I just realized that also a changelog is missing. I'll update all of this and push it to this PR, if you don't mind?

@RalfJung
Copy link
Member Author

RalfJung commented Oct 7, 2024

I have tried to fix the test. But yeah could be good if you could write the changelog. :)

@flip1995
Copy link
Member

flip1995 commented Oct 7, 2024

Pushed the changelog update and rebased on top of master.

@flip1995
Copy link
Member

flip1995 commented Oct 7, 2024

@bors r=Alexendoo,flip1995 p=10

@bors
Copy link
Collaborator

bors commented Oct 7, 2024

📌 Commit fba7ea7 has been approved by Alexendoo,flip1995

It is now in the queue for this repository.

@flip1995
Copy link
Member

flip1995 commented Oct 7, 2024

Published the new version and also bumped it in Clippy itself. Let's get this merged ASAP.

cc @dtolnay rustc_tools_util 0.4.0 is now available, which also includes your recent changes.

bors added a commit that referenced this pull request Oct 7, 2024
rustc_tools_util: rerun when git commit changes

Fixes #13312
@bors
Copy link
Collaborator

bors commented Oct 7, 2024

⌛ Testing commit fba7ea7 with merge 9b58331...

@bors
Copy link
Collaborator

bors commented Oct 7, 2024

💔 Test failed - checks-action_test

@flip1995
Copy link
Member

flip1995 commented Oct 7, 2024

@bors retry (missing changelog)

@bors
Copy link
Collaborator

bors commented Oct 7, 2024

⌛ Testing commit fba7ea7 with merge 6f4bf90...

@bors
Copy link
Collaborator

bors commented Oct 7, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo,flip1995
Pushing 6f4bf90 to master...

@bors bors merged commit 6f4bf90 into rust-lang:master Oct 7, 2024
11 checks passed
bors added a commit to rust-lang/miri that referenced this pull request Oct 7, 2024
RalfJung pushed a commit to RalfJung/rust that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustc_tools_util: does not emit any "rerun-if-changed"
6 participants