Rustup to rustc 1.15.0-nightly (0ed951993 2016-11-14) and bump to 0.0.99 #1344
Conversation
| }, | ||
| _ => (println!("boo"), break), //~ ERROR sub-expression diverges | ||
| _ => true || break, //~ ERROR sub-expression diverges |
There was a problem hiding this comment.
It looks like rustc is able to find some of those by itself now.
|
/me just realized that tests are super-slow because he had |
|
Well, tests pass locally now, but I want to review that later. There were some huge changes. |
| }, | ||
| hir::ItemUnion(..) => { | ||
| println!("union definition: {:?}", cx.tcx.opt_lookup_item_type(did)); | ||
| //println!("union definition: {:?}", cx.tcx.opt_lookup_item_type(did)); |
There was a problem hiding this comment.
Oops, forgot these, thanks dogfood 😅
There was a problem hiding this comment.
@oli-obk I don't really know what this should do and it does not appear to be tested. Could you help me there?
There was a problem hiding this comment.
Just change it to item_type or remove the info entirely just leaving the "union definition" text
push it, I'll do a review round |
| } else { | ||
| true | ||
| } | ||
| matches!(expr.node, ExprBlock(_)) |
There was a problem hiding this comment.
Note: add tests for that.
| .get_parent_node(borrow_id)) { | ||
| if adj.autoderefs <= 1 { | ||
| .map | ||
| .get_parent_node(borrow_id)) |
| if_let_chain! {[ | ||
| // just one expression in the closure | ||
| blk.stmts.is_empty(), | ||
| let Some(ref closure_expr) = blk.expr, | ||
| // nothing special in the argument, besides reference bindings |
There was a problem hiding this comment.
Note: Check that.
EDIT: done.
| ExprBlock(ref block) => Some(block), | ||
| _ => None, | ||
| } | ||
| } |
There was a problem hiding this comment.
Note: do we ever need the enclosing block of || 1?
EDIT: looks like not.
|
I took the liberty of appending to your PR |
Thanks. |
mcarton
changed the title
|
Almost 0.0.:100:!
|
This is compiling, but not working at all yet.
See rust-lang/rust#37402, rust-lang/rust#37408, rust-lang/rust#37412, rust-lang/rust#37688 and probably others.