Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collect attribute spans early for disallowed macros #13657

Merged
merged 1 commit into from
Nov 7, 2024
Merged

collect attribute spans early for disallowed macros #13657

merged 1 commit into from
Nov 7, 2024

Conversation

jdonszelmann
Copy link
Contributor

@jdonszelmann jdonszelmann commented Nov 5, 2024 •
edited by flip1995
Loading

filed here instead of rust-lang/rust (old: rust-lang/rust#132645)

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Nov 5, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 5, 2024
@jdonszelmann
Copy link
Contributor Author

r? @flip1995

@rustbot rustbot assigned flip1995 and unassigned Manishearth Nov 5, 2024
@jdonszelmann jdonszelmann mentioned this pull request Nov 5, 2024
Closed
GuillaumeGomez
GuillaumeGomez approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said on the original PR: looks good to me, thanks!

flip1995
flip1995 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@flip1995 flip1995 closed this Nov 7, 2024
@flip1995 flip1995 reopened this Nov 7, 2024
@flip1995 flip1995 added this pull request to the merge queue Nov 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2024
@flip1995 flip1995 added this pull request to the merge queue Nov 7, 2024
Merged via the queue into rust-lang:master with commit f712eb5 Nov 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@flip1995 flip1995

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jdonszelmann @rustbot @GuillaumeGomez @flip1995 @Manishearth