range_plus_one suggestion should not remove braces fix #3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
requested changes
Aug 30, 2018
clippy_lints/src/ranges.rs
Outdated
| /// **Known problems:** Will add unnecessary pair of parentheses when the | ||
| /// expression is not wrapped in a pair but starts with a opening parenthesis | ||
| /// and ends with a closing one. | ||
| /// I.e: let _ = (f()+1)..(f()+1) results in let _ = ((f()+1)..(f()+1)). |
There was a problem hiding this comment.
Backticks "`" around code missing. "results in let _ = ((f()+1)..=f())"
tests/ui/range_plus_minus_one.stderr
Outdated
| @@ -42,7 +42,7 @@ error: an inclusive range would be more readable | |||
| --> $DIR/range_plus_minus_one.rs:28:13 | |||
| | | |||
| 28 | let _ = (f()+1)..(f()+1); | |||
| | ^^^^^^^^^^^^^^^^ help: use: `(f()+1)..=f()` | |||
| | ^^^^^^^^^^^^^^^^ help: use: `((f()+1)..=f())` | |||
There was a problem hiding this comment.
Please add another test especially for the issue #3103 .
flip1995
added
the
S-waiting-on-author
flip1995
reviewed
Sep 3, 2018
clippy_lints/src/ranges.rs
Outdated
| /// **Known problems:** Will add unnecessary pair of parentheses when the | ||
| /// expression is not wrapped in a pair but starts with a opening parenthesis | ||
| /// and ends with a closing one. | ||
| /// I.e: `let _ = (f()+1)..(f()+1)` results in `let _ = ((f()+1)..(f()+1))`. |
There was a problem hiding this comment.
The second let _ = ((f()+1)..(f()+1)) should be let _ = ((f()+1)..=f())
flip1995
approved these changes
Sep 3, 2018
flip1995
requested changes
Sep 3, 2018
There was a problem hiding this comment.
Dogfood test is still failing.
https://travis-ci.org/rust-lang-nursery/rust-clippy/jobs/424066517#L1330-L1345
|
Hi! Could you leave the requested comment in #3230 for relicensing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking into #3103 decided to go with the first suggestion.
#3103 (comment)
Added information to the known problems that lint adds unnecessary parentheses if the expression is not wrapped in a pair but starts with a opening parenthesis and ends with a closing one.