Reintroduce extern crate for non-Cargo dependencies.
#3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dogfood is failing, can you just allow the failing lint? |
|
No, the lint was wrong. Also, it's very badly named IMO. |
|
Just confirmed that this fixes |
eddyb
added a commit
to eddyb/rls
that referenced
this pull request
Sep 15, 2018
eddyb
added a commit
to eddyb/rls
that referenced
this pull request
Sep 15, 2018
eddyb
added a commit
to eddyb/rls
that referenced
this pull request
Sep 15, 2018
eddyb
added a commit
to eddyb/rls
that referenced
this pull request
Sep 15, 2018
eddyb
added a commit
to eddyb/rls
that referenced
this pull request
Sep 15, 2018
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Sep 15, 2018
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rust-lang/rust#53166 (comment) for the decision. Needed for rust-lang/rust#54116.
Includes a revert for #3160, to allow updating
src/tools/clippyinrust-lang/rust.(cc @matthiaskrgr)