Adds lint for Vec<Box<T: Sized>> #3545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis error: |
oli-obk
reviewed
Dec 13, 2018
|
Yeah the current nightly doesn't have Just wait for the next nightly (or use a previous one). A good website to check the availability of tools in the latest nightlies is https://mexus.github.io/rustup-components-history/ |
flip1995
reviewed
Dec 13, 2018
Manishearth
reviewed
Dec 13, 2018
Manishearth
reviewed
Dec 13, 2018
Manishearth
reviewed
Dec 13, 2018
flip1995
reviewed
Dec 13, 2018
Manishearth
reviewed
Dec 13, 2018
|
All issues brought up so far have been addressed. |
|
Thanks! @bors r+ |
|
📌 Commit 985eba0 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 14, 2018
Adds lint for Vec<Box<T: Sized>> This adds, and subsequently closes #3530. This is the first time I've ever worked with anything remotely close to internal Rust code, so I'm very much unsure about the if_chain! to figure this out! I can't get rustfmt working on WSL with nightly 2018-12-07: `error: component 'rustfmt' for target 'x86_64-unknown-linux-gnu' is unavailable for download`
|
💔 Test failed - status-appveyor |
bors
added a commit
that referenced
this pull request
Dec 14, 2018
Adds lint for Vec<Box<T: Sized>> This adds, and subsequently closes #3530. This is the first time I've ever worked with anything remotely close to internal Rust code, so I'm very much unsure about the if_chain! to figure this out! I can't get rustfmt working on WSL with nightly 2018-12-07: `error: component 'rustfmt' for target 'x86_64-unknown-linux-gnu' is unavailable for download`
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds, and subsequently closes #3530. This is the first time I've ever worked with anything remotely close to internal Rust code, so I'm very much unsure about the if_chain! to figure this out!
I can't get rustfmt working on WSL with nightly 2018-12-07:
error: component 'rustfmt' for target 'x86_64-unknown-linux-gnu' is unavailable for download