Fix ICE in suspicious_else_formatting #3925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
phansch
added
the
S-waiting-on-review
phansch
commented
Apr 8, 2019
phansch
added
S-waiting-on-author
phansch
added
S-waiting-on-review
|
Thanks! @bors r+ |
|
📌 Commit 3ab8038 has been approved by |
bors
added a commit
that referenced
this pull request
Apr 9, 2019
Fix ICE in suspicious_else_formatting Fixes #3741
|
☀️ Test successful - checks-travis, status-appveyor |
phansch
added a commit
to phansch/rust-clippy
that referenced
this pull request
Apr 14, 2019
This was causing two different ICEs in rust-lang#3741. The first was fixed in rust-lang#3925. The second one is fixed with this commit: We just don't `expect` anymore. If the snippet doesn't contain an `else`, we stop emitting the lint because it's not a suspiciously formatted else anyway.
bors
added a commit
that referenced
this pull request
Apr 14, 2019
Remove `except` in suspicious_else_formatting 96c34e8 contains the fix: This was causing two different ICEs in #3741. The first was fixed in #3925. The second one is fixed with this commit: We just don't `expect` anymore. If the snippet doesn't contain an `else`, we stop emitting the lint because it's not a suspiciously formatted else anyway. Unfortunately I wasn't able to provide a minimal test case, but I think it's fine since it's just ignoring the `None` case now. And ad27e3f cleans up the lint code to use `if_chain`. Fixes #3741 once more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3741