Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't trigger assertions_on_constants on debug_assert!(false) #3989

Merged
merged 6 commits into from
Apr 19, 2019
Merged

Don't trigger assertions_on_constants on debug_assert!(false) #3989

merged 6 commits into from
Apr 19, 2019

Conversation

flip1995
Copy link
Member

Fixes #3948
Fixes #3765

changelog: Fix debug_assert! false positive on assertions_on_constants lint

@flip1995 flip1995 changed the title Assert on const Don't trigger assertions_on_constants on debug_assert!(false) Apr 18, 2019
@flip1995 flip1995 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 18, 2019
@phansch
Copy link
Member

phansch commented Apr 19, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Apr 19, 2019

📌 Commit 10cd289 has been approved by phansch

@bors
Copy link
Contributor

bors commented Apr 19, 2019

⌛ Testing commit 10cd289 with merge 12e8075...

bors added a commit that referenced this pull request Apr 19, 2019
@bors
Auto merge of #3989 - flip1995:assert_on_const, r=phansch
12e8075 
Don't trigger assertions_on_constants on debug_assert!(false)

Fixes #3948
Fixes #3765

changelog: Fix `debug_assert!` false positive on `assertions_on_constants` lint
@bors
Copy link
Contributor

bors commented Apr 19, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 12e8075 to master...

@bors bors merged commit 10cd289 into rust-lang:master Apr 19, 2019
@flip1995 flip1995 deleted the assert_on_const branch April 19, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansch phansch phansch left review comments

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
3 participants
@flip1995 @phansch @bors