Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macro check for unreadable_literal lint #4099

Merged
merged 1 commit into from
May 19, 2019
Merged

Conversation

flip1995
Copy link
Member

Closes #4094

changelog: Disable unreadable_literal lint inside macros

@flip1995 flip1995 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 15, 2019
@oli-obk
Copy link
Contributor

oli-obk commented May 17, 2019

@bors r+

@bors
Copy link
Contributor

bors commented May 17, 2019

📌 Commit 3543f58 has been approved by oli-obk

@bors
Copy link
Contributor

bors commented May 17, 2019

⌛ Testing commit 3543f58 with merge b8d2f48...

bors added a commit that referenced this pull request May 17, 2019
Add macro check for unreadable_literal lint

Closes #4094

changelog: Disable `unreadable_literal` lint inside macros
@bors
Copy link
Contributor

bors commented May 17, 2019

💔 Test failed - checks-travis

@phansch
Copy link
Member

phansch commented May 19, 2019

@bors retry

@bors
Copy link
Contributor

bors commented May 19, 2019

⌛ Testing commit 3543f58 with merge 4071b29...

bors added a commit that referenced this pull request May 19, 2019
Add macro check for unreadable_literal lint

Closes #4094

changelog: Disable `unreadable_literal` lint inside macros
@bors
Copy link
Contributor

bors commented May 19, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 4071b29 to master...

@bors bors merged commit 3543f58 into rust-lang:master May 19, 2019
@flip1995 flip1995 deleted the ul_4094 branch June 18, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No obvious way to format unreadable literals in generated code
4 participants