Rustup #4388
Merged
Rustup #4388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
try macro is deprecated now, so Clippy will drop the support for it also
Lint redundant_semicolon was added to rustc
This was referenced Aug 15, 2019
|
Maybe rustup this too: rust-lang/rust#62429 . |
|
rust-lang/rust#62429 didn't break anything, so we're good here. |
|
@bors r+ |
|
📌 Commit 87fa2d9 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 15, 2019
Rustup Supersedes #4387 and #4385 This removes tests with the `try!` macro in them completely. There is no need for Clippy to support the `try!` macro, since it is deprecated now. [`StmtKind`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc/hir/enum.StmtKind.html) got a new variant [`Semi`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc/hir/enum.StmtKind.html#variant.Semi), which Just Works™ with the `author` lint. Nice. changelog: none
|
💔 Test failed - checks-travis |
|
Unicode breaks the |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Aug 15, 2019
Rustup Supersedes #4387 and #4385 This removes tests with the `try!` macro in them completely. There is no need for Clippy to support the `try!` macro, since it is deprecated now. [`StmtKind`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc/hir/enum.StmtKind.html) got a new variant [`Semi`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc/hir/enum.StmtKind.html#variant.Semi), which Just Works with the `author` lint. Nice. changelog: none
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #4387 and #4385
This removes tests with the
try!macro in them completely. There is no need for Clippy to support thetry!macro, since it is deprecated now.StmtKindgot a new variantSemi, which Just Works with theauthorlint. Nice.changelog: none