Make more tests rustfixable #4558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
flip1995
reviewed
Sep 20, 2019
| @@ -2,7 +2,8 @@ | |||
| #[warn(clippy::eq_op)] | |||
| #[allow(clippy::identity_op, clippy::double_parens, clippy::many_single_char_names)] | |||
| #[allow(clippy::no_effect, unused_variables, clippy::unnecessary_operation, clippy::short_circuit_statement)] | |||
| #[warn(clippy::nonminimal_bool)] | |||
| #[allow(clippy::nonminimal_bool)] | |||
There was a problem hiding this comment.
I guess this is tested in another file? Everything else LGTM
phansch
reviewed
Sep 20, 2019
tests/ui/for_loop_unfixable.stderr
Outdated
| --> $DIR/for_loop_unfixable.rs:27:15 | ||
| | | ||
| LL | for _v in vec.iter().next() {} | ||
| | ^^^ help: use `!` to invoke the macro: `vec!` |
There was a problem hiding this comment.
The test file is missing the vec local.
Manishearth
force-pushed
the
suggestions
branch
from
6e4d646
to
b352c2d
Compare
|
@bors r=phansch |
|
📌 Commit b352c2d has been approved by |
|
💔 Test failed - checks-travis |
|
@bors retry |
|
💔 Test failed - status-appveyor |
|
|
Manishearth
force-pushed
the
suggestions
branch
from
b352c2d
to
33f1415
Compare
|
@bors r=phansch |
|
📌 Commit 33f1415 has been approved by |
|
💔 Test failed - status-appveyor |
Manishearth
force-pushed
the
suggestions
branch
from
33f1415
to
2fecf75
Compare
|
@bors r=phansch |
|
📌 Commit 2fecf75 has been approved by |
|
This is what i get for making a PR in a hurry because I didn't think I'd be back on my laptop until after my flight |
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Fix various lint suggestions
Progress towards #3630
r? @phansch