Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reserved keyword proc #175

Closed
wants to merge 3 commits into from
Closed

Add reserved keyword proc #175

wants to merge 3 commits into from

Conversation

ordovicia
Copy link

This PR adds proc to rustReservedKeyword.

@ordovicia
Copy link
Author

Ping?

Copy link

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about yield?

@ordovicia
Copy link
Author

ordovicia commented Feb 7, 2018

yield is already added to rustKeyword here as well as macro and box.

I'm not sure they should be registered as rustReservedKeyword.
They are in "reserved keywords" list in the book but can be used in nightly (unless I'm misunderstanding).

@pickfire
Copy link

pickfire commented Feb 7, 2018

@ordovicia It's true that it's nightly-only but it's experimental right? My fault that I didn't check deeper since the docs showed that it belong to "Keywords Reserved for Future Use".

@ordovicia
Copy link
Author

@pickfire Right. yield, macro, and box are all currently experimental (proc is not available even in nightly TMK).
@steveklabnik How do you think? Should these keywords belong to rustReservedKeyword?

@ordovicia
Copy link
Author

The proc keyword is going to be removed from the reserved keywords list (rust-lang/rust#49699).

@ordovicia
Copy link
Author

Closing this PR since the proc keyword has been removed.
IMHO other keywords e.g. yield should be discussed in a separate issue.

@ordovicia ordovicia closed this Apr 18, 2018
@ordovicia ordovicia deleted the add-proc-reserved-keyword branch October 28, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants