-
Notifications
You must be signed in to change notification settings - Fork 12.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auto merge of #41856 - qnighy:prohibit-parenthesized-params-in-more-t…
…ypes, r=arielb1 Prohibit parenthesized params in more types. Prohibit parenthesized parameters in primitive types, type parameters, `Self`, etc. Fixes #32995.
- Loading branch information
Showing
7 changed files
with
148 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| // Copyright 2017 The Rust Project Developers. See the COPYRIGHT | ||
| // file at the top-level directory of this distribution and at | ||
| // http://rust-lang.org/COPYRIGHT. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
| // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
| // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
||
| #![deny(parenthesized_params_in_types_and_modules)] | ||
| //~^ NOTE lint level defined here | ||
| //~| NOTE lint level defined here | ||
| //~| NOTE lint level defined here | ||
| #![allow(dead_code, unused_variables)] | ||
| #![feature(conservative_impl_trait)] | ||
|
|
||
| fn main() { | ||
| { fn f<X: ::std::marker()::Send>() {} } | ||
| //~^ ERROR parenthesized parameters may only be used with a trait | ||
| //~| WARN previously accepted | ||
| //~| NOTE issue #42238 | ||
|
|
||
| { fn f() -> impl ::std::marker()::Send { } } | ||
| //~^ ERROR parenthesized parameters may only be used with a trait | ||
| //~| WARN previously accepted | ||
| //~| NOTE issue #42238 | ||
| } | ||
|
|
||
| #[derive(Clone)] | ||
| struct X; | ||
|
|
||
| impl ::std::marker()::Copy for X {} | ||
| //~^ ERROR parenthesized parameters may only be used with a trait | ||
| //~| WARN previously accepted | ||
| //~| NOTE issue #42238 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| // Copyright 2017 The Rust Project Developers. See the COPYRIGHT | ||
| // file at the top-level directory of this distribution and at | ||
| // http://rust-lang.org/COPYRIGHT. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
| // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
| // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
||
| #![deny(parenthesized_params_in_types_and_modules)] | ||
| //~^ NOTE lint level defined here | ||
| //~| NOTE lint level defined here | ||
| //~| NOTE lint level defined here | ||
| //~| NOTE lint level defined here | ||
| //~| NOTE lint level defined here | ||
| //~| NOTE lint level defined here | ||
| //~| NOTE lint level defined here | ||
| #![allow(dead_code, unused_variables)] | ||
|
|
||
| fn main() { | ||
| let x: usize() = 1; | ||
| //~^ ERROR parenthesized parameters may only be used with a trait | ||
| //~| WARN previously accepted | ||
| //~| NOTE issue #42238 | ||
|
|
||
| let b: ::std::boxed()::Box<_> = Box::new(1); | ||
| //~^ ERROR parenthesized parameters may only be used with a trait | ||
| //~| WARN previously accepted | ||
| //~| NOTE issue #42238 | ||
|
|
||
| macro_rules! pathexpr { | ||
| ($p:path) => { $p } | ||
| } | ||
|
|
||
| let p = pathexpr!(::std::str()::from_utf8)(b"foo").unwrap(); | ||
| //~^ ERROR parenthesized parameters may only be used with a trait | ||
| //~| WARN previously accepted | ||
| //~| NOTE issue #42238 | ||
|
|
||
| let p = pathexpr!(::std::str::from_utf8())(b"foo").unwrap(); | ||
| //~^ ERROR parenthesized parameters may only be used with a trait | ||
| //~| WARN previously accepted | ||
| //~| NOTE issue #42238 | ||
|
|
||
| let o : Box<::std::marker()::Send> = Box::new(1); | ||
| //~^ ERROR parenthesized parameters may only be used with a trait | ||
| //~| WARN previously accepted | ||
| //~| NOTE issue #42238 | ||
|
|
||
| let o : Box<Send + ::std::marker()::Sync> = Box::new(1); | ||
| //~^ ERROR parenthesized parameters may only be used with a trait | ||
| //~| WARN previously accepted | ||
| //~| NOTE issue #42238 | ||
| } | ||
|
|
||
| fn foo<X:Default>() { | ||
| let d : X() = Default::default(); | ||
| //~^ ERROR parenthesized parameters may only be used with a trait | ||
| //~| WARN previously accepted | ||
| //~| NOTE issue #42238 | ||
| } |