Skip to content

Commit

Permalink
Rollup merge of #73861 - GuillaumeGomez:create-e0767, r=Dylan-DPC
Browse files Browse the repository at this point in the history
Create E0768

r? @Dylan-DPC
  • Loading branch information
Manishearth authored Jul 4, 2020
2 parents 9a659c5 + 6970c92 commit 6339abd
Show file tree
Hide file tree
Showing 6 changed files with 33 additions and 9 deletions.
1 change: 1 addition & 0 deletions src/librustc_error_codes/error_codes.rs
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,7 @@ E0764: include_str!("./error_codes/E0764.md"),
E0765: include_str!("./error_codes/E0765.md"),
E0766: include_str!("./error_codes/E0766.md"),
E0767: include_str!("./error_codes/E0767.md"),
E0768: include_str!("./error_codes/E0768.md"),
;
// E0006, // merged with E0005
// E0008, // cannot bind by-move into a pattern guard
Expand Down
13 changes: 13 additions & 0 deletions src/librustc_error_codes/error_codes/E0768.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
A number in a non-decimal base has no digits.

Erroneous code example:

```compile_fail,E0768
let s: i32 = 0b; // error!
```

To fix this error, add the missing digits:

```
let s: i32 = 0b1; // ok!
```
9 changes: 8 additions & 1 deletion src/librustc_parse/lexer/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,14 @@ impl<'a> StringReader<'a> {
}
rustc_lexer::LiteralKind::Int { base, empty_int } => {
return if empty_int {
self.err_span_(start, suffix_start, "no valid digits found for number");
self.sess
.span_diagnostic
.struct_span_err_with_code(
self.mk_sp(start, suffix_start),
"no valid digits found for number",
error_code!(E0768),
)
.emit();
(token::Integer, sym::integer(0))
} else {
self.validate_int_literal(base, start, suffix_start);
Expand Down
3 changes: 2 additions & 1 deletion src/test/ui/parser/issue-1802-1.stderr
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
error: no valid digits found for number
error[E0768]: no valid digits found for number
--> $DIR/issue-1802-1.rs:5:16
|
LL | log(error, 0b);
| ^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0768`.
3 changes: 2 additions & 1 deletion src/test/ui/parser/issue-1802-2.stderr
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
error: no valid digits found for number
error[E0768]: no valid digits found for number
--> $DIR/issue-1802-2.rs:5:16
|
LL | log(error, 0b);
| ^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0768`.
13 changes: 7 additions & 6 deletions src/test/ui/parser/lex-bad-numeric-literals.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ error: hexadecimal float literal is not supported
LL | 0x9.0e-9;
| ^^^^^^^^

error: no valid digits found for number
error[E0768]: no valid digits found for number
--> $DIR/lex-bad-numeric-literals.rs:11:5
|
LL | 0o;
Expand All @@ -64,31 +64,31 @@ error: hexadecimal float literal is not supported
LL | 0x539.0;
| ^^^^^^^

error: no valid digits found for number
error[E0768]: no valid digits found for number
--> $DIR/lex-bad-numeric-literals.rs:18:5
|
LL | 0x;
| ^^

error: no valid digits found for number
error[E0768]: no valid digits found for number
--> $DIR/lex-bad-numeric-literals.rs:19:5
|
LL | 0xu32;
| ^^

error: no valid digits found for number
error[E0768]: no valid digits found for number
--> $DIR/lex-bad-numeric-literals.rs:20:5
|
LL | 0ou32;
| ^^

error: no valid digits found for number
error[E0768]: no valid digits found for number
--> $DIR/lex-bad-numeric-literals.rs:21:5
|
LL | 0bu32;
| ^^

error: no valid digits found for number
error[E0768]: no valid digits found for number
--> $DIR/lex-bad-numeric-literals.rs:22:5
|
LL | 0b;
Expand Down Expand Up @@ -138,3 +138,4 @@ LL | 0b101f64;

error: aborting due to 23 previous errors

For more information about this error, try `rustc --explain E0768`.

0 comments on commit 6339abd

Please sign in to comment.